Skip to content

Generic: Preserve ONLY as an unquoted table name - #3003

Merged
LucaCappelletti94 merged 1 commit into
apache:mainfrom
blaginin:db/fix-only-table-name
Nov 18, 2026
Merged

LucaCappelletti94 merged 1 commit into
apache:mainfrom
blaginin:db/fix-only-table-name

Conversation

@blaginin

Copy link
Copy Markdown
Member

related to #2770
and apache/datafusion#27063 (comment)

When you SELECT * from ONLY t it can mean:

  • read table t without descendant tables
  • read table ONLY with alias t

different systems pick different sides 😄

image

let's disable this by default?

Once merged, I think we should also port this to the previous release

@blaginin blaginin self-assigned this Nov 18, 2026
@blaginin blaginin added the bug Something isn't working label Nov 18, 2026
@github-actions

Copy link
Copy Markdown

No dialect label was applied because the title does not name a SQL dialect.

If this change targets one or more dialects, edit the title to <Dialect>[, <Dialect>]: <description>, add a Dialects: <Dialect>[, <Dialect>] line to the description, or reply with one. Reply Dialects: none if the change is dialect-agnostic.

Changed files touch PostgreSQL.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.29%. Comparing base (9429cd3) to head (01c9c23).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3003      +/-   ##
==========================================
- Coverage   83.29%   83.29%   -0.01%     
==========================================
  Files          42       42              
  Lines       35378    35375       -3     
  Branches    35378    35375       -3     
==========================================
- Hits        29469    29466       -3     
  Misses       2456     2456              
  Partials     3453     3453              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@blaginin
blaginin marked this pull request as ready for review November 18, 2026 20:05

@LucaCappelletti94 LucaCappelletti94 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

cc @alamb

@LucaCappelletti94
LucaCappelletti94 added this pull request to the merge queue Nov 18, 2026
Merged via the queue into apache:main with commit 97afe81 Nov 18, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants